[Davical-dev] Internationalisation-Patch

[Andrew McMillan]

On Thu, 2009-10-29 at 13:43 +0100, Matthias Mohr wrote:
> Hi Andrew,
> 
> >> The patch also removes all unnecessary sprintf where no parameters are given...
> > 
> > I'd happily apply a patch covering just that :-)
> Attached are simpler patches, which don't add the array functionality
> to $c->messages assignments (and output).

Both are applied to HEAD now.


>    - It fixes some message assignment in libawl (assignments made to the non 
> existing $client_messages array instead of $c->messages).

A holdover from some other older applications which use AWL.  Hopefully
everything that uses AWL has been switched to $c->messages now.


>    - changes some calls from "i18n" to "translate" in assignments to
>        $c->messages where paramters are given
>      This is the unclean solution of the original patch; just to make sure,
>        the format strings get translated before they'll combined with the
>        variable contents
>        (unclean, because the strings will be sent twice through "translate":
>         first as "format string" and a second time when alredy translated and
>         after replacment of the variables with their contents...)

Given the content of the strings is error messages, such as ones sourced
from PostgreSQL, I don't think there is a better way for much of it.


> The patches are pretty small, so I think it's O.K. to combine the above things 
> in only two patches...

Yep.  There was only one reject when applying this to HEAD, and it was
easily resolved.

Patches with a small consistent change to many files, or a larger
consistent change to few files are both OK.  The first kind will *look*
larger, of course, due to the amount of context in the patch.

Cheers,
					Andrew.

------------------------------------------------------------------------
andrew (AT) morphoss (DOT) com                            +64(272)DEBIAN
               You are taking yourself far too seriously.
------------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.morphoss.com/pipermail/davical-dev/attachments/20091030/e479d484/attachment.pgp>