[Davical-dev] Internationalisation-Patch

Matthias Mohr Matthias at Mohrenclan.de
Fri Oct 30 01:43:32 NZDT 2009


Hi Andrew,

>> The patch also removes all unnecessary sprintf where no parameters are given...
> 
> I'd happily apply a patch covering just that :-)
Attached are simpler patches, which don't add the array functionality
to $c->messages assignments (and output).
   - It fixes some message assignment in libawl (assignments made to the non 
existing $client_messages array instead of $c->messages).
   - removes all unnecessary sprintf where no parameters are given...
   - adds some calls to "i18n" where they were missing.
   - changes some calls from "translate" to "i18n" in assignments to
       $c->messages where no parameters are given
     (this messages will be translated later in page-header.php)
   - changes some calls from "i18n" to "translate" in assignments to
       $c->messages where paramters are given
     This is the unclean solution of the original patch; just to make sure,
       the format strings get translated before they'll combined with the
       variable contents
       (unclean, because the strings will be sent twice through "translate":
        first as "format string" and a second time when alredy translated and
        after replacment of the variables with their contents...)

The patches are pretty small, so I think it's O.K. to combine the above things 
in only two patches...

kind regards,
Matthias
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: awl-0.38_internationalisation_simpler.diff
URL: <http://lists.morphoss.com/pipermail/davical-dev/attachments/20091029/b57fff7f/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: davical-0.9.7.6_internationalisation_simpler.diff
URL: <http://lists.morphoss.com/pipermail/davical-dev/attachments/20091029/b57fff7f/attachment.asc>


More information about the Davical-dev mailing list